fix(deps): adjust dependencies required for grails 7 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeconsole
previously requested changes
Oct 11, 2024
jamesfredley
changed the title
…e plugin in build.gradle only
implementation("com.bertramlabs.plugins:asset-pipeline-gradle:5.0.1") in buildSrc/build.gradle was requiring the extra graal-sdk dependency
jamesfredley
changed the title
matrei
approved these changes
Oct 11, 2024
jamesfredley
changed the title
|
I am not sure |
|
Once that is in place, we will remove it here. 7.0.0-SNAPSHOT is currently an option on start.grails.org and this enables the generated application to start, for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are currently required to start a grails 7 web project.
The
graal-sdkdependency will be handled as follows: bertramdev/asset-pipeline#352 (comment)After removing the asset-pipeline Gradle plugin from
buildSrc/build.gradleandsetting.gradleand defining it in one locationbuild.gradle, thegraal-sdkdependency is no longer needed.The larger consolidation of buildSrc, settings.gradle and build.gradle will occur on #347