Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fragmentArguments): arguments on directives for nested fields #4180

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Sep 6, 2024

fixes up just merged #4015

this was actually intended to be in #4015, but due to branch confusion not originally included

now we also have a test!

@yaacovCR yaacovCR requested a review from a team as a code owner September 6, 2024 14:06
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 062232c
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66db12a6fdf37800082aa899
😎 Deploy Preview https://deploy-preview-4180--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 6, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title remove unused optional portion of CollectFieldsContext update collectFields with latest edits for fragment args Sep 6, 2024
this was actually intended to be in graphql#4015, but due to branch confusion not originally included

now we also have a test
@yaacovCR yaacovCR changed the title update collectFields with latest edits for fragment args @yaacovCR fix(fragmentArguments): arguments on directives for nested fields Sep 6, 2024
@yaacovCR yaacovCR changed the title @yaacovCR fix(fragmentArguments): arguments on directives for nested fields fix(fragmentArguments): arguments on directives for nested fields Sep 6, 2024
@yaacovCR yaacovCR merged commit 1dbdadc into graphql:main Sep 6, 2024
20 checks passed
@yaacovCR yaacovCR deleted the remove-unused branch September 6, 2024 14:43
@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants