Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PHP 8.4 compatibility #20

wants to merge 1 commit into from

Conversation

andypost
Copy link

@andypost andypost commented Jul 23, 2024

RFC https://php.watch/rfcs/deprecate-implicitly-nullable-types

Testing via docker

expander$ docker run --rm -v $(pwd):/mnt -w /mnt php:8.4.0alpha2-cli-alpine find . -type f -name '*.php' -exec php -l {} \;
No syntax errors detected in ./tests/src/ExpanderTest.php
No syntax errors detected in ./src/StringifierInterface.php

Deprecated: Grasmash\Expander\Expander::doExpandArrayProperties(): Implicitly marking parameter $reference_data as nullable is deprecated, the explicit nullable type must be used instead in ./src/Expander.php on line 102

Deprecated: Grasmash\Expander\Expander::expandStringPropertiesCallback(): Implicitly marking parameter $reference_data as nullable is deprecated, the explicit nullable type must be used instead in ./src/Expander.php on line 201
No syntax errors detected in ./src/Expander.php
No syntax errors detected in ./src/Stringifier.php

Copy link

@weitzman weitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weitzman
Copy link

Ping @grasmash

@ptmkenny
Copy link

@grasmash PHP 8.4 has been officially released, so it would be great to get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants