Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: unconfigure FPGA before reading flash UID #103

Closed
wants to merge 1 commit into from
Closed

cli: unconfigure FPGA before reading flash UID #103

wants to merge 1 commit into from

Conversation

mossmann
Copy link
Member

@mossmann mossmann commented Jul 9, 2024 •
edited
Loading

Fix #102

@mossmann mossmann marked this pull request as draft July 9, 2024 14:59
@mossmann mossmann marked this pull request as ready for review July 9, 2024 15:02
@mossmann mossmann requested review from antoinevg and mndza July 9, 2024 15:10
@mossmann mossmann marked this pull request as draft July 9, 2024 16:28
@mossmann
Copy link
Member Author

mossmann commented Jul 9, 2024

This requires a more thought because, as @miek pointed out, calling unconfigure() every time is kind of like forcing --force-offline.

@mossmann
Copy link
Member Author

replaced by #107

@mossmann mossmann closed this Jul 20, 2024
@mossmann mossmann deleted the flash-uid-fix branch July 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinevg antoinevg Awaiting requested review from antoinevg

@mndza mndza Awaiting requested review from mndza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flash UID zeros after --force-offline
1 participant
@mossmann