Show more warnings, clean up some.

include/pyro/vector.h

@@ -106,13 +106,14 @@ namespace Pyro
             return !this->operator<(rhs);
         }
 
-        Vector &operator=(const Vector &rhs)
+        // Removed 2024-04-01, not needed? Gives a lot of warnings.
+        /*Vector &operator=(const Vector &rhs)
         {
             this->x = rhs.x;
             this->y = rhs.y;
             this->z = rhs.z;
             return *this;
-        }
+        }*/
 
         float dist(const Vector &other) const;
         float dot(const Vector &other) const;

meson.build

@@ -3,6 +3,8 @@ project('Pyro', 'cpp',
         license: 'GPLv3',
         default_options: ['cpp_std=c++17'])
 
+
+
 freetype_dep = dependency('freetype2')
 libjpeg_dep = dependency('libjpeg')
 libpng_dep = dependency('libpng')

src/image.cpp

@@ -454,7 +454,7 @@ namespace Pyro
 
         // png_write_info(png_ptr, info_ptr);
 
-        png_bytep row_pointers[this->_pixelheight];
+        std::vector<png_bytep> row_pointers;
 
         uint8_t *converted_data{nullptr};
         unsigned int stride{this->_pixelwidth};
@@ -488,10 +488,10 @@ namespace Pyro
         png_bytep data = (png_bytep)converted_data;
         for (unsigned int y = 0; y < this->_pixelheight; y++)
         {
-            row_pointers[y] = &(data[y * stride]);
+            row_pointers.push_back(&(data[y * stride]));
         }
 
-        png_set_rows(png_ptr, info_ptr, row_pointers);
+        png_set_rows(png_ptr, info_ptr, &row_pointers[0]);
         // png_write_image(png_ptr, row_pointers);
         // png_write_end(png_ptr, NULL);
         png_write_png(png_ptr, info_ptr, PNG_TRANSFORM_BGR, NULL);
@@ -796,9 +796,9 @@ namespace Pyro
         uint32_t b = abs(int((dst & BLUE_MASK) - (src & BLUE_MASK)));
         uint32_t g = abs(int((dst & GREEN_MASK) - (src & GREEN_MASK)));
 
-        uint32_t rb = (r < 0 ? -r : r) |
-                      (b < 0 ? -b : b);
-        uint32_t gn = (g < 0 ? -g : g);
+        uint32_t rb = r |
+                      b;
+        uint32_t gn = g;
 
         return min((dst >> 24) + a, 0xFFu) << 24 |
                (((dst & RB_MASK) * d_a + rb * s_a) >> 8 & RB_MASK) |

src/meson.build

@@ -1,3 +1,5 @@
+cpp_args = ['-Wall', '-Wextra', '-Wpedantic',]
+
 pyro_sources = ['pyro.cpp',
                 'runner.cpp',
                 'sdl.cpp',
@@ -19,4 +21,5 @@ pyrolib = library('pyro',
                   pyro_sources, 
                   include_directories: inc_dir,
                   dependencies: [libpng_dep, cairo_dep, libjpeg_dep, freetype_dep, sdl_dep, eigen_dep],
+                  cpp_args: cpp_args,
                   install: false)