Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 Compliance (Accessibility) #130

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

iamanissa
Copy link

This makes the modal accessible to people with disabilities.

What is 508 Compliance?
Section 508, is an amendment to the United States Workforce Rehabilitation Act of 1973, is a federal law mandating that all electronic and information technology developed, procured, maintained, or used by the federal government be accessible to people with disabilities. 508 Compliance, therefore, involves developing a website that can be used by people with limited vision or blindness, deafness, seizure disorders, and other disabilities.

What issues were fixed?

  1. The visual focus does not remain within the modal dialog box until closed.
    • Trapped focus within modal using javascript
  2. “Every x days text box” needs markup to associate it to its complete instructions and cues.
    • Added aria-label to input box for each frequency dropdown item.
  3. The contrast ratio is less than 4.5:1 for content background and foreground colors.
    • When selecting Weekly days, Monthly Day of Month, and Monthly Day of Week links, the color wasn’t dark enough so I changed the color from #89a to #64717F
  4. Weekly and Monthly day links do not have a unique and meaningful description.
    • Added aria-labels to each a tag
  5. Monthly Days of Month and Monthly Days of Week cannot be accessed or activated by keyboard.
    • When selecting Weekly days, Monthly Day of Month, and Monthly Day of Week, each a tag needed an href in order to be tabbable.

iamanissa and others added 22 commits May 17, 2019 12:38
@iamanissa iamanissa closed this Jul 15, 2019
@iamanissa iamanissa reopened this Jul 15, 2019
@iamanissa
Copy link
Author

Didn't mean to close this PR, I'm new to Forking and all that. I only meant to merge an update to my own Fork.
I still need this PR to be reviewed and merged. I am using my Forked version at work.

saturnflyer added a commit to saturnflyer/ice_cube_select that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant