[SG-10] Refactor Cipher data model

src/Api/Models/Request/CipherRequestModel.cs

@@ -22,6 +22,7 @@ public class CipherRequestModel
         public string FolderId { get; set; }
         public bool Favorite { get; set; }
         public CipherRepromptType Reprompt { get; set; }
+        public EncObject Data { get; set; }
         [Required]
         [EncryptedString]
         [EncryptedStringLength(1000)]
@@ -86,7 +87,8 @@ public Cipher ToCipher(Cipher existingCipher)
                     existingCipher.Data = JsonSerializer.Serialize(ToCipherSecureNoteData(), JsonHelpers.IgnoreWritingNull);
                     break;
                 default:
-                    throw new ArgumentException("Unsupported type: " + nameof(Type) + ".");
+                    existingCipher.Data = JsonSerializer.Serialize(Data, JsonHelpers.IgnoreWritingNull);
+                    break;
             }
 
             existingCipher.Reprompt = Reprompt;
@@ -227,7 +229,6 @@ private CipherSecureNoteData ToCipherSecureNoteData()
                 Notes = Notes,
                 Fields = Fields?.Select(f => f.ToCipherFieldData()),
                 PasswordHistory = PasswordHistory?.Select(ph => ph.ToCipherPasswordHistoryData()),
-
                 Type = SecureNote.Type,
             };
         }

src/Api/Models/Response/CipherResponseModel.cs

@@ -52,13 +52,19 @@ public CipherMiniResponseModel(Cipher cipher, IGlobalSettings globalSettings, bo
                     Identity = new CipherIdentityModel(identityData);
                     break;
                 default:
-                    throw new ArgumentException("Unsupported " + nameof(Type) + ".");
+                    var customData = JsonSerializer.Deserialize<EncObject>(cipher.Data);
+                    Data = customData;
+                    cipherData = null;
+                    break;
             }
 
-            Name = cipherData.Name;
-            Notes = cipherData.Notes;
-            Fields = cipherData.Fields?.Select(f => new CipherFieldModel(f));
-            PasswordHistory = cipherData.PasswordHistory?.Select(ph => new CipherPasswordHistoryModel(ph));
+            if (cipherData != null)
+            {
+                Name = cipherData.Name;
+                Notes = cipherData.Notes;
+                Fields = cipherData.Fields?.Select(f => new CipherFieldModel(f));
+                PasswordHistory = cipherData.PasswordHistory?.Select(ph => new CipherPasswordHistoryModel(ph));
+            }
             RevisionDate = cipher.RevisionDate;
             OrganizationId = cipher.OrganizationId?.ToString();
             Attachments = AttachmentResponseModel.FromCipher(cipher, globalSettings);

src/Core/Enums/CipherType.cs

@@ -7,6 +7,6 @@ public enum CipherType : byte
         Login = 1,
         SecureNote = 2,
         Card = 3,
-        Identity = 4
+        Identity = 4,
     }
 }

src/Core/Models/Data/EncObject.cs

@@ -0,0 +1,12 @@
+using Bit.Core.Enums;
+
+namespace Bit.Core.Models.Data
+{
+    public class EncObject
+    {
+        public EncryptionType Type { get; set; }
+        public string Data { get; set; }
+        public string Iv { get; set; }
+        public string Mac { get; set; }
+    }
+}