Issue 23: Display public IP address #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method to get and display public IP address in the server verbose
gridhead
requested changes
Oct 23, 2020
| @@ -2,6 +2,7 @@ | |||
| from prompt_toolkit import print_formatted_text, HTML | |||
| from websockets.exceptions import ConnectionClosedError | |||
| from utils.helper_display import HelperDisplay | |||
| from requests import get | |||
There was a problem hiding this comment.
requests is quite a heavy module to import for task as small as this. Also, we cannot just assume that the users have curl or wget binaries installed on their distribution which makes it a difficult point to discuss about.
Comment on lines
+32
to
+33
| def ipaddress(): | ||
| return get('https://api64.ipify.org').text |
There was a problem hiding this comment.
This does a great job in retrieving an IPv6 address as evidenced in the screenshot I have attached just below.
But when it comes to IPv4, it still ends up fetching the IPv6 address.
| servenow(netpdata, chatport) | ||
| except OSError: | ||
| print_formatted_text(HTML("[" + obtntime() + "] " + "<b>SNCTRYZERO</b> > <red><b>The server could not be started up</b></red>")) |
There was a problem hiding this comment.
Nice touch with the corrected message. 😉
|
Any updates, @shivangswain? |
|
Yeah, changing the whole implementation to use urllib3. ETA: 30 mins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to fetch and display public IP address in the server verbose
Linked Issue: #23