Improved IP address fetch & display #87
Conversation
There was a problem hiding this comment.
You would want to make the lines L#117 and L#121, the part of the ipaddress function so as to avoid repeating the same parts of code. Also, please make use of a try-except block in the function to address the cases when the server providing those addresses is unreachable.
(Don't worry about the specificity of the exception. Just catch one and let the user know that the addresses could not be fetched.)
| def ipaddress(v): | ||
| url = "https://api64.ipify.org" | ||
| if v == 4: | ||
| url = "https://api.ipify.org" | ||
| elif v == 6: | ||
| url = "https://api6.ipify.org" | ||
| response = urllib3.PoolManager().request('GET', url) | ||
| return response.data.decode('UTF-8') |
There was a problem hiding this comment.
Nice work done with fetching distinct addresses.
| @@ -1,4 +1,4 @@ | |||
| import asyncio, websockets, sys, click, time, os | |||
| import asyncio, websockets, sys, click, urllib3, time | |||
There was a problem hiding this comment.
urllib3 is a not-so elegant module but lightweight - something which is perfect for our usecase. Thanks for replacing requests in favour of this module.
|
Just pushed a new, even simpler and faster implementation |
Added a simple & better method to fetch and display public IP address in the server verbose
Closes #23