Issue 23: IP address fetch and display #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 30, 2020 21:55
Added exception text and implemented the most fundamental known method to http request
gridhead
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Looks good to me. @shivangswain please go ahead and merge this PR.
| @@ -1,4 +1,4 @@ | |||
| import asyncio, websockets, sys, click, time, os | |||
| import asyncio, websockets, sys, click, http.client, time | |||
There was a problem hiding this comment.
That's as optimized as it gets. Good work!
| connection.request("GET", "/") | ||
| response = connection.getresponse() | ||
| return response.read().decode("UTF-8") | ||
| except: |
There was a problem hiding this comment.
The generalized exception handling would prevent service crashes in all times.
gridhead
added a commit
that referenced
this pull request
Oct 30, 2020
Signed-off-by: t0xic0der <[email protected]>
shivangswain
pushed a commit
that referenced
this pull request
Oct 30, 2020
Added logistical changes to complement #90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the most fundamental method to fetch and display public IP address in the server verbose with exception handling
Closes #23