Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post upgrade fixes #15

Merged
merged 6 commits into from
Jun 19, 2017
Merged

Post upgrade fixes #15

merged 6 commits into from
Jun 19, 2017

Conversation

safts
Copy link
Contributor

@safts safts commented Jun 13, 2017

  • Add missing migrations in peers app
  • Move static files, reform settings to allow django.contrib.staticfiles to serve them correctly
    during development
  • Fix nxpy requirement (until we provide our upstream)

Sergios Aftsidis added 3 commits June 13, 2017 15:08
This migration was missing. As a result the intermediate m2m tables
were not created.
To serve static files during development, `django.contrib.staticfiles`
can either find static files in apps directories (not our case)
or in some additional directories defined in `STATICFILES_DIRS`.
However, one cannot include `STATIC_ROOT` in `STATICFILES_DIRS` (since
this is where the static files will be copied when using `./manage.py
collectstatic`. To fix that:

* Move static files in another directory (`BASE_DIR + 'flowspy/static'`)
* Add this directory in `STATICFILES_DIRS`
@safts safts requested a review from ioparaskev June 13, 2017 13:20
@safts
Copy link
Contributor Author

safts commented Jun 13, 2017

Please don't merge yet, still testing.

@safts safts merged commit 1c8f205 into grnet:django18upgrade Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants