Detect a memory leak as a test failure #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, grntest detect a memory leak as a test failure. However, grntest may return success even if grntest detect memory leak if we specify the --n-retries option. Because grntest return success when a test successful even once while retry test. I modification that grntest return false when a test fail cause of memory leak even once in this PR.
kou
reviewed
Feb 2, 2023
| @@ -181,6 +185,7 @@ def run_test(test_script_path, test_name) | |||
|
|
|||
| runner = TestRunner.new(@tester, self) | |||
| return true if runner.run | |||
| return false if @result.n_leaked_tests > 0 | |||
There was a problem hiding this comment.
Why do we need this?
It seems that TestRunner#run returns false when leaked test exists: https://github.com/groonga/grntest/blob/master/lib/grntest/test-runner.rb#L111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, grntest detect a memory leak as a test failure. However, grntest may return success even if grntest detect memory leak if we specify the --n-retries option.
Because grntest return success when a test successful even once while retry test.
I modification that grntest return false when a test fail cause of memory leak even once in this PR.