Drop ruby_parser and sexp_processor dev dependencies #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the ruby_parser code was removed in grosser#201, there were a few remnants, including these dev dependencies. Note that this commit also updates nio4r and sqlite3 as I couldn't get those older gem version to compile on my machine.
Fryguy
force-pushed
the
drop_ruby_parser
branch
from
6710490 to
8d7711d
Compare
Fryguy
changed the title
|
@grosser the tests here failed on Ruby 2.7, but you merged anyway. Should I fix in a separate pr or is the thought that we are just going to drop 2.7 support at some point? |
|
Oh nvm, I just saw that you merged #206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the ruby_parser code was removed in #201, there were a few remnants, including these dev dependencies.
Note that this commit also updates nio4r and sqlite3 as I couldn't get those older gem version to compile on my machine.