feat: add append_comment option to reverse_lookup_filter (rime#699)

Allow reverse_lookup_filter to append new codes to existing comments
groverlynn · Sep 27, 2023 · a71a8f6 · a71a8f6
1 parent 194b4dd
commit a71a8f6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/rime/gear/reverse_lookup_filter.cc b/src/rime/gear/reverse_lookup_filter.cc
@@ -53,6 +53,7 @@ void ReverseLookupFilter::Initialize() {
   }
   if (Config* config = engine_->schema()->config()) {
     config->GetBool(name_space_ + "/overwrite_comment", &overwrite_comment_);
+    config->GetBool(name_space_ + "/append_comment", &append_comment_);
     comment_formatter_.Load(config->GetList(name_space_ + "/comment_format"));
   }
 }
@@ -69,7 +70,7 @@ an<Translation> ReverseLookupFilter::Apply(an<Translation> translation,
 }
 
 void ReverseLookupFilter::Process(const an<Candidate>& cand) {
-  if (!overwrite_comment_ && !cand->comment().empty())
+  if (!cand->comment().empty() && !(overwrite_comment_ || append_comment_))
     return;
   auto phrase = As<Phrase>(Candidate::GetGenuineCandidate(cand));
   if (!phrase)
@@ -78,7 +79,11 @@ void ReverseLookupFilter::Process(const an<Candidate>& cand) {
   if (rev_dict_->ReverseLookup(phrase->text(), &codes)) {
     comment_formatter_.Apply(&codes);
     if (!codes.empty()) {
-      phrase->set_comment(codes);
+      if (overwrite_comment_) {
+        phrase->set_comment(codes);
+      } else if (append_comment_) {
+        phrase->set_comment(cand->comment() + " " + codes);
+      }
     }
   }
 }

diff --git a/src/rime/gear/reverse_lookup_filter.h b/src/rime/gear/reverse_lookup_filter.h
@@ -34,6 +34,7 @@ class ReverseLookupFilter : public Filter, TagMatching {
   the<ReverseLookupDictionary> rev_dict_;
   // settings
   bool overwrite_comment_ = false;
+  bool append_comment_ = false;
   Projection comment_formatter_;
 };