fix(time-picker): error

growingio · Sep 9, 2024 · 3c0d8a2 · 3c0d8a2
1 parent a265659
commit 3c0d8a2
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/static-past-time-picker/StaticPastTimePicker.tsx b/src/static-past-time-picker/StaticPastTimePicker.tsx
@@ -67,9 +67,13 @@ function StaticPastTimePicker({
     ],
     [experimental, localLocale]
   );
-  const options = useMemo(() => quickOptions || localQuickOptions, [quickOptions, localQuickOptions]);
-
-  earliestApprove && options.push({ value: 'earliest', label: localLocale.earliestInHistory });
+  const options = useMemo(
+    () => [
+      ...(quickOptions || localQuickOptions),
+      ...(earliestApprove ? [{ value: 'earliest', label: localLocale.earliestInHistory }] : []),
+    ],
+    [quickOptions, localQuickOptions, earliestApprove, localLocale]
+  );
 
   const parseMode = useCallback((current: string | undefined) => parseTimeMode(current, options), [options]);
   const originMode = (parseMode(timeRange) ?? TimeMode.Quick) as TimeMode;