fix: ANLSPI-18506 crash when dismiss action sheet triggered by popove…

…r dimming view
growingio · May 23, 2024 · cd7f2e0 · cd7f2e0
1 parent 36802f1
commit cd7f2e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/GrowingAutotrackerCore/Autotrack/UIAlertController+GrowingAutotracker.h b/GrowingAutotrackerCore/Autotrack/UIAlertController+GrowingAutotracker.h
@@ -27,7 +27,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)growing_dismissAnimated:(BOOL)animated
                  triggeringAction:(UIAlertAction *)action
-    triggeredByPopoverDimmingView:(UIView *)view
+    triggeredByPopoverDimmingView:(BOOL)isTriggeredByPopoverDimmingView
                 dismissCompletion:(id)completion;
 
 + (nullable UIAlertAction *)growing_actionForActionView:(UIView *)actionView;

diff --git a/GrowingAutotrackerCore/Autotrack/UIAlertController+GrowingAutotracker.m b/GrowingAutotrackerCore/Autotrack/UIAlertController+GrowingAutotracker.m
@@ -34,13 +34,15 @@ - (void)growing_dismissAnimated:(BOOL)animated triggeringAction:(UIAlertAction *
 
 - (void)growing_dismissAnimated:(BOOL)animated
                  triggeringAction:(UIAlertAction *)action
-    triggeredByPopoverDimmingView:(UIView *)view
+    triggeredByPopoverDimmingView:(BOOL)isTriggeredByPopoverDimmingView
                 dismissCompletion:(id)completion {
-    [self growing_sendClickEventForAction:action];
+    if (completion) {
+        [self growing_sendClickEventForAction:action];
+    }
 
     [self growing_dismissAnimated:animated
                      triggeringAction:action
-        triggeredByPopoverDimmingView:view
+        triggeredByPopoverDimmingView:isTriggeredByPopoverDimmingView
                     dismissCompletion:completion];
 }