feat: abTesting request timeout config

growingio · Nov 29, 2023 · d7edac6 · d7edac6
1 parent e946d4f
commit d7edac6
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/Example/GrowingAnalyticsTests/GrowingAnalyticsStartTests/GrowingAnalyticsStartTests.m b/Example/GrowingAnalyticsTests/GrowingAnalyticsStartTests/GrowingAnalyticsStartTests.m
@@ -148,7 +148,6 @@ - (void)testSetConfiguration_Autotracker {
     config.dataSourceId = @"12345";
     GrowingNetworkConfig *networkConfig = [GrowingNetworkConfig config];
     networkConfig.requestTimeout = 0.3f;
-    networkConfig.abTestingRequestTimeout = 0.5f;
     config.networkConfig = networkConfig;
     [GrowingRealAutotracker trackerWithConfiguration:config launchOptions:nil];
 
@@ -170,7 +169,6 @@ - (void)testSetConfiguration_Autotracker {
     XCTAssertEqualObjects(configuration.dataSourceId, @"12345");
     XCTAssertNotNil(configuration.networkConfig);
     XCTAssertEqual(configuration.networkConfig.requestTimeout, 0.3f);
-    XCTAssertEqual(configuration.networkConfig.abTestingRequestTimeout, 0.5f);
 }
 
 - (void)testDefaultConfiguration_Tracker {
@@ -211,7 +209,6 @@ - (void)testSetConfiguration_Tracker {
     config.dataSourceId = @"12345";
     GrowingNetworkConfig *networkConfig = [GrowingNetworkConfig config];
     networkConfig.requestTimeout = 0.3f;
-    networkConfig.abTestingRequestTimeout = 0.5f;
     config.networkConfig = networkConfig;
     [GrowingRealTracker trackerWithConfiguration:config launchOptions:nil];
 
@@ -231,7 +228,6 @@ - (void)testSetConfiguration_Tracker {
     XCTAssertEqualObjects(configuration.dataSourceId, @"12345");
     XCTAssertNotNil(configuration.networkConfig);
     XCTAssertEqual(configuration.networkConfig.requestTimeout, 0.3f);
-    XCTAssertEqual(configuration.networkConfig.abTestingRequestTimeout, 0.5f);
 }
 
 - (void)testVersionNameAndVersionCode {

diff --git a/Example/GrowingAnalyticsTests/ModulesTests/ABTestingTests/ABTestingTests.m b/Example/GrowingAnalyticsTests/ModulesTests/ABTestingTests/ABTestingTests.m
@@ -61,6 +61,9 @@ + (void)setUp {
     configuration.urlScheme = @"growing.530c8231345c492d";
     configuration.abTestingServerHost = @"https://www.example.com";
     configuration.experimentTTL = 5.0f;
+    GrowingNetworkConfig *networkConfig = [GrowingNetworkConfig config];
+    networkConfig.abTestingRequestTimeout = 3.0f;
+    configuration.networkConfig = networkConfig;
     [GrowingAutotracker startWithConfiguration:configuration launchOptions:nil];
 }
 

diff --git a/GrowingTrackerCore/Network/Request/GrowingNetworkConfig.m b/GrowingTrackerCore/Network/Request/GrowingNetworkConfig.m
@@ -19,6 +19,13 @@
 
 #import "GrowingTrackerCore/Public/GrowingNetworkConfig.h"
 
+@interface GrowingNetworkConfig ()
+
+// ABTesting
+@property (nonatomic, assign) NSTimeInterval abTestingRequestTimeout;
+
+@end
+
 @implementation GrowingNetworkConfig
 
 - (instancetype)init {

diff --git a/GrowingTrackerCore/Public/GrowingNetworkConfig.h b/GrowingTrackerCore/Public/GrowingNetworkConfig.h
@@ -23,7 +23,6 @@ NS_SWIFT_NAME(NetworkConfig)
 @interface GrowingNetworkConfig : NSObject <NSCopying>
 
 @property (nonatomic, assign) NSTimeInterval requestTimeout;
-@property (nonatomic, assign) NSTimeInterval abTestingRequestTimeout;
 
 + (instancetype)config;
 

diff --git a/Modules/ABTesting/Public/GrowingABTesting.h b/Modules/ABTesting/Public/GrowingABTesting.h
@@ -42,4 +42,10 @@ NS_SWIFT_NAME(ABTesting)
 
 @end
 
+@interface GrowingNetworkConfig (ABTesting)
+
+@property (nonatomic, assign) NSTimeInterval abTestingRequestTimeout;
+
+@end
+
 NS_ASSUME_NONNULL_END