added simple arty calculator #8

NeutraleNull · 2022-09-28T00:11:33Z

Implemented my idea from #2

It works together with the artillery table, or more say more clearly, it does not work without one.
First you select your charge from the table, then head over to self interact -> easy arty -> start.
Just click on the map and a solution will be shown if available. Otherwise a error message will be shown.
You can switch the charge and your own position and the solution will be updated accordingly.

NeutraleNull · 2022-09-28T00:13:37Z

Code can still need some improvements here and there (the estimation of the elevation between two settings is not that great).

diwako · 2022-09-28T08:20:07Z

scripts/easyarty/funcs.hpp

+    tag = "easyarty";
+    class functions {
+        file = "scripts\easyarty\functions";
+        class preInit{preInit = 1;};


If preinit is not needed, do not include

diwako · 2022-09-28T08:20:29Z

scripts/easyarty/functions/fn_calculate.sqf

+
+private _az = (_vehicle getDir _targetPos) * DEGREE_TO_MIL_FACTOR;
+
+_distanceToTarget = _vehicle distance artyTarget;


missing private keywords for new variable declarations

diwako · 2022-09-28T08:21:24Z

scripts/easyarty/functions/fn_postInit.sqf

@@ -0,0 +1,64 @@
+if (isDedicated) exitWith {};


use this instead, covers headless client as well then

if !(hasinterface) exitWith {};

diwako · 2022-09-28T08:22:13Z

scripts/easyarty/functions/fn_postInit.sqf

@@ -0,0 +1,64 @@
+if (isDedicated) exitWith {};
+easyArtyRunning = false;


heavily suggesting the use of proper prefixing
easyarty_running
easyarty_pfh
easyarty_displayEh

this means it becomes less problematic moving the script to other missions or even a mod some time in the future

diwako · 2022-09-28T08:23:03Z

scripts/easyarty/functions/fn_postInit.sqf

+easyArtyDisplayEh = -1;
+
+private _spacerAction = [
+    "spacerEasyArty",


use prefixes for the action IDs

diwako · 2022-09-28T08:23:58Z

scripts/easyarty/functions/fn_postInit.sqf

+    1,
+    ["ACE_SelfActions"],
+    _spacerAction
+] call ace_interact_menu_fnc_addActionToObject;


use ace_interact_menu_fnc_addActionToClass instead, else a respawn will break this.

diwako · 2022-09-28T08:25:14Z

scripts/easyarty/functions/fn_setTargetPos.sqf

+	params ["", "_pos"];
+	deleteMarker "target_loc";
+	_marker = createMarkerLocal ["target_loc", _pos];
+	_marker setMarkerType "HD_DOT";


this will make the marker global, i doubt you want this. Also use prefixing for the marker name.

diwako · 2022-09-28T08:28:16Z

scripts/easyarty/functions/fn_setTargetPos.sqf

+private _mapClickEh = addMissionEventHandler ["MapSingleClick", {
+	params ["", "_pos"];
+	deleteMarker "target_loc";
+	_marker = createMarkerLocal ["target_loc", _pos];


missing private keyword

diwako · 2022-09-28T08:28:31Z

scripts/easyarty/functions/fn_setTargetPos.sqf

+
+private _mapClickEh = addMissionEventHandler ["MapSingleClick", {
+	params ["", "_pos"];
+	deleteMarker "target_loc";


global delete of a none global marker.

NeutraleNull · 2022-09-28T11:42:59Z

Updated the code according to @diwako suggestions. Many thanks for the review :)
Also added back in the functionality to switch between low and high shell arc.

NeutraleNull · 2022-09-28T20:19:09Z

Fixed shells landing short and included time on target to view.
Here a little video showing how it works, and how precise it can be:
https://youtu.be/mqoG4zK83Xw

b-mayr-1984 · 2022-10-08T14:18:34Z

Here a little video showing how it works, and how precise it can be: https://youtu.be/mqoG4zK83Xw

I tried it and immediately got confused. After I went in game I immediately tried the new self ACE menu point.

This message showed up which did not explain to me what the problem was or how I should even come up with a solution.

Only in connection with your YT video I managed to make progress by clicking in the range card (without knowing what I am doing).

I also noticed that the Easy Arty ACE menu items are visible if you have no range cards with you. To my understanding Easy Arty can not work without range cards and if so should not be made available in the first place.

NeutraleNull · 2022-10-08T14:52:34Z

scripts/easyarty/functions/fn_postInit.sqf

+    "Easy Arty",
+    "",
+    {},
+    {true}


tobe added [player, "ACE_artilleryTable"] call BIS_fnc_hasItem instead of true

check if a player has an artillery table before adding the spacer action to his player

NeutraleNull · 2023-06-30T09:38:19Z

@b-mayr-1984 wie ist der Stand der Dinge hier?

b-mayr-1984 · 2023-06-30T09:58:07Z

@b-mayr-1984 wie ist der Stand der Dinge hier?

Ich hab hier auf den Input gewartet den du mir noch geben wolltest.
https://discord.com/channels/@me/1000698946135543809/1028337333839351920

Hab dann einige Wochen später nochmal nachgefragt bei dir, aber leider keine Antwort erhalten.
https://discord.com/channels/@me/969958150377730119/1055892275424665600

Daher ist aus meiner Sicht gerade der Stand on hold.

Um das zu mergen bräuchte es mMn konsistentes Verhalten, denn sonst sehe ich Spielerfrust vorprogrammiert wenn es nur in manchen Fällen funktioniert.

Daher nochmal die Frage:
@NeutraleNull willst du hier noch was tun um das zu stabilisieren bzw. konsistent zu machen?
Wenn die Behebung sich zu schwierig gestalten würde, dann könnte man es für die Spieler im User Interface evtl. als dediziertes Experimental Feature deklarieren, welches known issues hat (macht RHS towing ja auch).

NeutraleNull · 2023-07-01T17:49:15Z

Alles klar, ich würde es Stable für Arty nennen. Mörser funktionieren ja damit -noch- nicht. Schaue ich mir aber auf jeden Fall mal an.

b-mayr-1984 · 2023-07-01T17:55:37Z

Alles klar, ich würde es Stable für Arty nennen. Mörser funktionieren ja damit -noch- nicht. Schaue ich mir aber auf jeden Fall mal an.

Passt. Solange die Nutzerführung das mit fehlendem Mörser-Support widerspiegelt (z.B. durch entsprechendes benennen der ACE-Menüeinträge), soll mir (und hoffentlich den Spielern) das reichen.

Wenn du Mörser auch noch an's Laufen kriegen möchtest, sogar noch besser. 🙂

added simple arty calculator

603a841

NeutraleNull requested a review from diwako September 28, 2022 00:13

NeutraleNull added the enhancement New feature or request label Sep 28, 2022

diwako requested changes Sep 28, 2022

View reviewed changes

updated code as suggested in PR review

03bec20

NeutraleNull added 2 commits September 28, 2022 13:43

amend missing change

db99327

fixed shells landing short and included tot to view

d0fdb23

NeutraleNull requested a review from diwako September 28, 2022 20:21

NeutraleNull commented Oct 8, 2022

View reviewed changes

check if player has an artillery table

f1562c9

check if a player has an artillery table before adding the spacer action to his player

b-mayr-1984 assigned NeutraleNull Jul 15, 2023

b-mayr-1984 marked this pull request as draft April 1, 2024 12:31

b-mayr-1984 force-pushed the main branch from eb7b522 to 9772031 Compare June 2, 2024 17:41

b-mayr-1984 force-pushed the main branch from 5f68807 to 8b06f13 Compare July 7, 2024 15:08

b-mayr-1984 force-pushed the main branch from 1c1050e to 198b0d5 Compare July 21, 2024 16:44

b-mayr-1984 force-pushed the main branch from 9e20436 to 0f683d2 Compare August 13, 2024 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added simple arty calculator #8

added simple arty calculator #8

NeutraleNull commented Sep 28, 2022

NeutraleNull commented Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

diwako Sep 28, 2022

NeutraleNull commented Sep 28, 2022

NeutraleNull commented Sep 28, 2022

b-mayr-1984 commented Oct 8, 2022

NeutraleNull Oct 8, 2022

NeutraleNull commented Jun 30, 2023

b-mayr-1984 commented Jun 30, 2023

NeutraleNull commented Jul 1, 2023

b-mayr-1984 commented Jul 1, 2023


		private _az = (_vehicle getDir _targetPos) * DEGREE_TO_MIL_FACTOR;

		_distanceToTarget = _vehicle distance artyTarget;

		@@ -0,0 +1,64 @@
		if (isDedicated) exitWith {};
		easyArtyRunning = false;

added simple arty calculator #8

Are you sure you want to change the base?

added simple arty calculator #8

Conversation

NeutraleNull commented Sep 28, 2022

NeutraleNull commented Sep 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NeutraleNull commented Sep 28, 2022

NeutraleNull commented Sep 28, 2022

b-mayr-1984 commented Oct 8, 2022

Choose a reason for hiding this comment

NeutraleNull commented Jun 30, 2023

b-mayr-1984 commented Jun 30, 2023

NeutraleNull commented Jul 1, 2023

b-mayr-1984 commented Jul 1, 2023