Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline element #414

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add timeline element #414

merged 2 commits into from
Apr 3, 2024

Conversation

davidfurey
Copy link
Member

@davidfurey davidfurey commented Mar 26, 2024

What does this change?

Updates content-api-model to latest version which includes the new timeline element. Currently set to a preview release, this should be updated to a proper release once guardian/content-api-models#245 is merged

@gu-scala-library-release
Copy link
Contributor

@davidfurey has published a preview version of this PR with release workflow run #46, based on commit 5c88d13:

26.0.0-PREVIEW.timeline-model.2024-03-26T1100.5c88d136

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the timeline-model branch, or use the GitHub CLI command:

gh workflow run release.yml --ref timeline-model

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@davidfurey davidfurey changed the title Bump CAPI models to version that includes new timeline element Add timeline element Mar 28, 2024
@Fweddi Fweddi marked this pull request as ready for review April 3, 2024 14:16
@Fweddi Fweddi requested a review from a team as a code owner April 3, 2024 14:16
Copy link
Contributor

@Divs-B Divs-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Regarding failing CI, the workaround is -

We had this similar failing issue in Apple-news and @rtyley mentioned to fix it by upgrading the version to v2.
PR for reference: https://github.com/guardian/apple-news/pull/320
Let us know if you have any questions.

@Fweddi
Copy link
Contributor

Fweddi commented Apr 3, 2024

Thanks @Divs-B, I have raised a PR to address your suggestion: #416.

@Fweddi Fweddi merged commit ff190e3 into main Apr 3, 2024
2 checks passed
@Fweddi Fweddi deleted the timeline-model branch April 3, 2024 15:17
Fweddi added a commit to guardian/facia-scala-client that referenced this pull request Apr 3, 2024
This brings in the timeline element changes (guardian/content-api-scala-client#414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants