Various CI fixes, including avoiding push as a CI trigger
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divs-B
force-pushed
the
db-rt/adjust-test-results
branch
from
764b638 to
85aba9e
Compare
We are doing this because push is very bad choice of trigger for CI on github PRs. Example: guardian/mobile-apps-api#2760 Co-authored-Roberto Tyley
rtyley
changed the title
push as a CI trigger
rtyley
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Co-authored: @rtyley
We are making various CI fixes including using pull request trigger(0e4149e)
because
pushevent is very bad choice of trigger for CI on github PRs.Example: https://github.com/guardian/mobile-apps-api/pull/2760
We also updating Test results to get accumulated in
test-resultsfolder.How to test
Raise this as PR (not Draft) and observe CI tests.
How can we measure success?
CI tests should pass on PR