Define CustomField #177
Draft
Define CustomField #177
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fweddi
force-pushed
the
fp/define-custom-fields
branch
2 times, most recently
from
3f22665 to
aee622d
Compare
Fweddi
force-pushed
the
fp/define-custom-fields
branch
from
aee622d to
9082e3a
Compare
Fweddi
commented
Dec 16, 2024
| struct CustomField { | ||
| 1: required string fieldName | ||
| 2: required string fieldType | ||
| 3: required string defaultValue |
There was a problem hiding this comment.
string is the best we can do for defaultValue as Thrift doesn't support polymorphism.
I assume we will fill defaultValue with stringified JSON.
|
@Fweddi has published a preview version of this PR with release workflow run #23, based on commit 9082e3a: 7.0.0-PREVIEW.fpdefine-custom-fields.2024-12-16T1530.9082e3ad Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fp/define-custom-fields branch, or use the GitHub CLI command: gh workflow run release.yml --ref fp/define-custom-fields Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.