-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated ContainerOverrides
wrapper around FrontSection
and LabsSection
components
#12931
Merged
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
changed the title
remove container overrides wrapper for FrontSection and LabsSection c…
Remove duplicated Nov 29, 2024
ContainerOverrides
wrapper around FrontSection
and LabsSection
components
…omponents since these components have container overrides inside them so are currently being duplicated unnecessarily
cemms1
force-pushed
the
cemms1/deduplicate-container-overrides
branch
from
November 29, 2024 17:50
e966c45
to
c6d40df
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Nov 29, 2024
Size Change: 0 B Total Size: 958 kB ℹ️ View Unchanged
|
arelra
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes
ContainerOverrides
wrappers from theFrontSection
andLabsSection
components inFrontLayout
because these components already useContainerOverrides
at the top level with them.Why?
Resolves small, palette inheritance bug in side border colours extending above the horizontal rule
Also tidies up the rendering tree, removing unnecessary duplication and bulk
Screenshots