Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary and secondary options to the list of tags #331

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Oct 24, 2024

What does this change?

Part of the fairgound project, specifically this ticket. Adds primary and secondary options to the list of available tags - which will be used to adjust the styling on platforms.

How can we measure success?

Can be seen in the list of tags in facia tool using the preview release :

image

Have we considered potential risks?

Images

Accessibility

Deployment

  • Updated facia-tool to use latest version
  • Updated frontend to use latest version
  • Updated MAPI to use latest version
  • Updated Ophan to use latest version
  • Updated story-packages to use latest version
  • Updated apple-news to use latest version
  • Checked for other downstream dependencies (perhaps via snyk or github search)

@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #43, based on commit e6de7d0:

12.1.0-PREVIEW.gladd-primarysecondary-tags.2024-10-24T1603.e6de7d0d

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/add-primary/secondary-tags branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/add-primary/secondary-tags

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@Georges-GNM Georges-GNM self-assigned this Oct 25, 2024
@Georges-GNM Georges-GNM changed the title Add primary and secondary tags Add primary and secondary options to the list of tags Oct 25, 2024
@Georges-GNM Georges-GNM marked this pull request as ready for review October 25, 2024 08:54
Copy link
Contributor

@waisingyiu waisingyiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thank you @Georges-GNM !

@Georges-GNM Georges-GNM merged commit d23c0fb into main Oct 25, 2024
10 checks passed
@Georges-GNM Georges-GNM deleted the gl/add-primary/secondary-tags branch October 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants