upgrade v1 libs #1525
Merged
upgrade v1 libs #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Had a poke around in CODE but couldn't find anything looking like a chart. From a glance at the code it sounds like it's used for sparklines, but I'm not 100% sure what that is either!
There are some tests for sparklines which reference highcharts and which I can see are passing in the CI build logs. Between that and the fact that CODE seems to be behaving as normal, I'm inclined to say this update is ok.
|
Seen on PROD (merged by @twrichards 16 minutes and 4 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because!