Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring-clean of frontend v2 modules #1567

Merged
merged 2 commits into from
May 1, 2024
Merged

Spring-clean of frontend v2 modules #1567

merged 2 commits into from
May 1, 2024

Conversation

fredex42
Copy link
Contributor

@fredex42 fredex42 commented Apr 25, 2024

What's changed?

  • Weeding out un-needed javascript modules to reduce vuln exposure

Before

Screenshot 2024-04-26 at 09 04 46

After

Screenshot 2024-04-26 at 09 03 57

Implementation notes

Most of these modules relate to Webpack and the old building process; things like Babel are still included, but as indirect dependencies whose versions we are no longer tying down (and therefore they update more easily).

I removed markdown-toc because it has not been updated in a long time and was bringing in a critical lodash vuln. It's a shame because it's a nifty feature on the README but it's not the end of the world

Checklist

General

  • 🤖 Relevant tests added <-- n/a
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@fredex42 fredex42 requested a review from a team as a code owner April 25, 2024 20:28
@fredex42 fredex42 marked this pull request as draft April 25, 2024 20:29
@fredex42 fredex42 force-pushed the ag/cleanout-modules branch from 1f577fa to 77903d6 Compare April 29, 2024 11:18
@fredex42 fredex42 marked this pull request as ready for review April 29, 2024 11:20
Copy link
Contributor

@jonathonherbert jonathonherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in CODE. LGTM. Lovely 👏

@fredex42 fredex42 merged commit 376246c into main May 1, 2024
9 checks passed
@fredex42 fredex42 deleted the ag/cleanout-modules branch May 1, 2024 09:29
@fredex42 fredex42 restored the ag/cleanout-modules branch May 1, 2024 09:29
@fredex42 fredex42 deleted the ag/cleanout-modules branch May 1, 2024 09:30
@prout-bot
Copy link

Seen on PROD (merged by @fredex42 6 minutes and 22 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants