Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove red ink in integration test runs #1568

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

jonathonherbert
Copy link
Contributor

What's changed?

In chatting about #1566 with @fredex42, some error logging when running integration tests was causing confusion. This PR should remove it. See the commits for individual fixes.

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@jonathonherbert jonathonherbert requested a review from a team as a code owner April 26, 2024 08:55
@jonathonherbert jonathonherbert force-pushed the jsh/fix-integration-test-red-ink branch from 990b7a6 to a0a6f59 Compare April 26, 2024 08:55
Copy link
Contributor

@fredex42 fredex42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@fredex42 fredex42 mentioned this pull request Apr 29, 2024
8 tasks
@jonathonherbert jonathonherbert merged commit bef6071 into main Apr 29, 2024
1 check passed
@jonathonherbert jonathonherbert deleted the jsh/fix-integration-test-red-ink branch April 29, 2024 10:49
@prout-bot
Copy link

Seen on PROD (merged by @jonathonherbert 9 minutes and 33 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants