Adopt GHA Scala library release workflow #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
reviewed
Jul 26, 2024
Co-authored-by: Roberto Tyley <[email protected]>
ioannakok
commented
Jul 26, 2024
* Added a .tool_versions file * Removed unecessary plugin * Small refactoring of the `build.sbt` Co-authored-by: Roberto Tyley <[email protected]>
This was referenced Jul 26, 2024
Merged
rtyley
added a commit
that referenced
this pull request
Dec 11, 2024
This library has had some version -number confusion: * 0.4.4 - 2023/03/17 - updated version.sbt * 0.5.0 - 2023/04/28 - did not update version.sbt - https://github.com/guardian/fastly-api-client/releases/tag/v0.5.0 * 0.6.0 - 2023/05/05 - did not update version.sbt - did not get a `git` tag * 0.4.5 - 2024/07/26 - picked up this smaller version number based on what was in version.sbt * 0.4.6 - 2023/07/30 * ...etc This repo adopted `gha-scala-library-release-workflow` with #47 in 2024/07/26 - before that the release procedure was much more manual and error-prone! To get past the confusion, it's best to jump to a version number higher than 0.6.0 - and as this library, like all libraries that use `gha-scala-library-release-workflow`, is using `early-semver`, it makes sense to move past 0.y.z as a version number - under `early-semver`: > When the major version is 0, a minor version increment MAY contain both source and binary breakages, but a patch version increment MUST remain binary compatible. To avoid the complication of trying to understand that, better to just get to v1 and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/guardian/gha-scala-library-release-workflow
This is the Guardian standard for releasing new artifacts to Sonatype. See similar PRs here: guardian/gha-scala-library-release-workflow#20