searchWithModifiers also in Collections panel #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperboyo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously, in #4252, Alt- and Shift- modifiers to exclude and add were added to Collection badges on thumbnails and to Collection info in the Info Panel (which is broken and works only on single image). This PR adds the familiar functionality to the Collections panel. This makes UI behave more consistently and makes it easier to make Collection-based searches.
How should a reviewer test this change?
Run a search. Hold Shift and click on a Collection in the panel. Hold Alt and do the same. Observe extra conditions in the searchbox.
How can success be measured?
In our hearts. And minds.
Tested? Documented?