Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canada strike message #1429

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Canada strike message #1429

merged 4 commits into from
Dec 13, 2024

Conversation

rBangay
Copy link
Contributor

@rBangay rBangay commented Dec 12, 2024

What does this PR change?

Add a message/alert to the top of the account overview page for Canadian customers who have a Guardian Weekly or Tier Three subscription while the Canadian post strike is active informing them that they can suspend their deliveries.

Images

Screenshot 2024-12-13 at 11 38 29

…stomers with either a Guardian weekly or tier three subscription to let them know about suspending their deliveries while the Canadian post strike is active
@rBangay rBangay requested a review from a team December 12, 2024 14:57
Copy link
Contributor

@ecguardian ecguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines 25 to 28
href="mailto:[email protected]"
priority="primary"
>
[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the difference in these email address domains? I assume it should match the provided copy

Suggested change
href="mailto:customer.help@theguardian.com"
priority="primary"
>
customer.help@guardian.co.uk
href="mailto:customer.help@guardian.co.uk"
priority="primary"
>
customer.help@guardian.co.uk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep thanks for spotting that John 👍

return (
(product.tier === 'Tier Three' ||
product.tier === 'Guardian Weekly - ROW') &&
product.billingCountry === 'Canada'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed we could use product.deliveryAddress.country here (if it's getting through) to make it more accurate. That (from MDAPI) contains the mailing address from salesforce.
It might also be worth toLowerCaseing it as there are a notable amount of CANADAs (not to mention a few CAs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ... yep I've changed to use the delivery address instead of the billing address and accounted for differing cases and 'CA'

@rBangay rBangay merged commit 1c582c4 into main Dec 13, 2024
13 checks passed
@rBangay rBangay deleted the canada-strike-message branch December 13, 2024 11:40
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @rBangay 9 minutes and 33 seconds ago) Please check your changes!

Comment on lines +206 to +207
(product.tier === 'Tier Three' ||
product.tier === 'Guardian Weekly - ROW') &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can GW in Canada not be `'Guardian Weekly - Domestic'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants