-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canada strike message #1429
Canada strike message #1429
Conversation
…stomers with either a Guardian weekly or tier three subscription to let them know about suspending their deliveries while the Canadian post strike is active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
href="mailto:[email protected]" | ||
priority="primary" | ||
> | ||
[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the difference in these email address domains? I assume it should match the provided copy
href="mailto:customer.help@theguardian.com" | |
priority="primary" | |
> | |
customer.help@guardian.co.uk | |
href="mailto:customer.help@guardian.co.uk" | |
priority="primary" | |
> | |
customer.help@guardian.co.uk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep thanks for spotting that John 👍
return ( | ||
(product.tier === 'Tier Three' || | ||
product.tier === 'Guardian Weekly - ROW') && | ||
product.billingCountry === 'Canada' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed we could use product.deliveryAddress.country here (if it's getting through) to make it more accurate. That (from MDAPI) contains the mailing address from salesforce.
It might also be worth toLowerCaseing it as there are a notable amount of CANADA
s (not to mention a few CA
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ... yep I've changed to use the delivery address instead of the billing address and accounted for differing cases and 'CA'
…nstead of the billing address country
… the caanda mail strike message condition
(product.tier === 'Tier Three' || | ||
product.tier === 'Guardian Weekly - ROW') && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can GW in Canada not be `'Guardian Weekly - Domestic'?
What does this PR change?
Add a message/alert to the top of the account overview page for Canadian customers who have a Guardian Weekly or Tier Three subscription while the Canadian post strike is active informing them that they can suspend their deliveries.
Images