Update built.sbt to support Scala 3 cross compile #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
scala-3-cross-compile
branch
from
d13e9d4 to
d834252
Compare
JamieB-gu
force-pushed
the
scala-3-cross-compile
branch
from
d834252 to
ed8257b
Compare
rtyley
commented
Feb 1, 2023
| com.gu.marley.AvroEnumSchema( | ||
| ${Expr(typ.typeSymbol.name)}, | ||
| ${Expr(pkg)}, | ||
| ${listMethod}.map(_.name).map(com.gu.marley.enumsymbols.SnakesOnACamel.toSnake) |
There was a problem hiding this comment.
The invocation of ${listMethod} currently doesn't compile, we see an error like this:
[error] -- [E007] Type Mismatch Error: /Users/Roberto_Tyley/code/marley/core/src/main/scala-3/com/gu/marley/AvroSerialisableMacro.scala:27:18
[error] 27 | ${listMethod}.map(_.name).map(com.gu.marley.enumsymbols.SnakesOnACamel.toSnake)
[error] | ^^^^^^^^^^
[error] | Found: (listMethod : x$1.reflect.Symbol)
[error] | Required: quoted.Expr[Any]
I've opened https://stackoverflow.com/q/75309058/438886 to see if anyone can suggest how to get this compiling!
There was a problem hiding this comment.
@JamieB-gu it looks like there's a very promising answer to the question on stackoverflow, I might take a look at trying it out tomorrow!
- Dropped support for Scala 2.12.x - Fixed some sbt warnings caused by "in" syntax - Replaced `versionDependent` helper with `CrossVersion` - Updated some libraries to get Scala 3 versions
rtyley
force-pushed
the
scala-3-cross-compile
branch
from
2fcbff7 to
f1970a3
Compare
- Added explicit type annotations for implicits as required by Scala 3 - Moved a Scala 2 macro class into a Scala 2 version-specific directory because these macros are unsupported in Scala 3
rtyley
force-pushed
the
scala-3-cross-compile
branch
from
f1970a3 to
9775ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionDependenthelper withCrossVersion