Add fields for tag list page #139
Conversation
|
@lindseydew has published a preview version of this PR with release workflow run #125, based on commit d540757: 1.0.42-PREVIEW.ldadd-fields-for-tag-list-page.2024-12-12T1618.d540757a Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ld/add-fields-for-tag-list-page branch, or use the GitHub CLI command: gh workflow run release.yml --ref ld/add-fields-for-tag-list-page Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
| optional MyGuardianFollow my_guardian_follow = 2; | ||
| optional string description = 3; | ||
| HeaderType alignment = 4; | ||
| optional Branding branding = 5; |
There was a problem hiding this comment.
The message List has a property branding too. Are there scenarios they would be different? Can we use the branding there?
There was a problem hiding this comment.
Yeah, there is a bit of a duplication here.
The idea behind it was to make the Header message atomic and with all the fields in order to be able to render it in different contexts.
What does this change?
This adds a
HEADERobject that will be used in the List endpoint in order to present the new tag pageHow to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility