Fix release problem with secret-generator
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releasing v1.0.0 with https://github.com/guardian/gha-scala-library-release-workflow worked fine, but trying to release v1.0.1 failed, due to the unusual configuration of the `secret-generator` subproject: https://github.com/guardian/play-secret-rotation/actions/runs/7113763098/job/19366398526#step:4:153 ``` [error] (aws-parameterstore-lambda / mimaPreviousClassfiles) sbt.librarymanagement.ResolveException: Error downloading com.gu.play-secret-rotation:secret-generator_2.13:1.0.0 [error] Not found [error] Not found [error] not found: /home/runner/.ivy2/localcom.gu.play-secret-rotation/secret-generator_2.13/1.0.0/ivys/ivy.xml [error] not found: https://repo1.maven.org/maven2/com/gu/play-secret-rotation/secret-generator_2.13/1.0.0/secret-generator_2.13-1.0.0.pom [error] (aws-parameterstore-lambda / versionPolicyFindDependencyIssues) sbt.librarymanagement.ResolveException: Error downloading com.gu.play-secret-rotation:secret-generator_2.13:1.0.0 ``` Nothing actually needs `secret-generator` as a library artifact - `aws-parameterstore-lambda` uses `sbt-assembly` to incorporate all it's dependencies into a single jar, so even though it uses secret-generator, it doesn't need it as a separate artifact. However, the new compatibility-based version-numbering functionality introduced in scalacenter/sbt-version-policy#187 wants to compare with previous versions of project dependencies, and it doesn't understand the dependency isn't published... It's easier to publish the artifact, so I'm doing that here!
rtyley
added a commit
that referenced
this pull request
Dec 6, 2023
rtyley
added a commit
that referenced
this pull request
Dec 6, 2023
… to #417" This reverts commit 088d4f5 - now that https://github.com/guardian/play-secret-rotation/releases/tag/v1.0.1 has published a `secret-generator` artifact, we can re-enable sbt-version-policy version numbering. #417
rtyley
deleted the
fix-release-problem-where-secret-generator-was-confusing-sbt-version-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing v1.0.0 with
gha-scala-library-release-workflow(introduced with PR #416) worked fine, but trying to release v1.0.1 failed, due to the unusual configuration of thesecret-generatorsubproject:https://github.com/guardian/play-secret-rotation/actions/runs/7113763098/job/19366398526#step:4:153
Why wasn't
secret-generatorconfigured to be published?Nothing actually needs
secret-generatoras a library artifact -aws-parameterstore-lambdausessbt-assemblyto incorporate all it's dependencies into a single jar, so even though it uses secret-generator, it doesn't need it as a separate artifact. However, the new compatibility-based version-numbering functionality introduced in scalacenter/sbt-version-policy#187 wants to compare with previous versions of project dependencies, and it doesn't understand the dependency isn't published...The easiest fix for this problem is just to publish the artifact, so I'm doing that here!
Note that after merging this PR, I also had to temporarily disable
sbt-version-policyversion numbering with 088d4f5, so that the next release would actually succeed (because it then wasn't looking for a previoussecret-generatorartifact) and publish thesecret-generatorartifact. Once release v1.0.1 succeeded, I re-enabledsbt-version-policyversion numbering with cf46179. The next release (v2.0.0) then completed successfully 👍