Make packages baked into images by Amigo visible to the service catalogue #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-chappell
force-pushed
the
kc/package-table
branch
3 times, most recently
from
16eaedf to
22cb7f1
Compare
kelvin-chappell
force-pushed
the
kc/package-table
branch
from
cc8f2a9 to
ef319d1
Compare
kelvin-chappell
changed the title
|
Should we also add the |
akash1810
reviewed
Dec 3, 2024
Comment on lines
+597
to
+604
| const packagesBucketName = new GuStringParameter( | ||
| scope, | ||
| 'packagesBucketNameParam', | ||
| { | ||
| fromSSM: true, | ||
| default: `/${stage}/deploy/amigo/amigo.data.bucket`, | ||
| }, | ||
| ).valueAsString; |
There was a problem hiding this comment.
Who creates/owns this SSM Parameter? Could it be created by AMIgo, as it creates the bucket?
There was a problem hiding this comment.
I think it's created by Amigo as it pre-exists this integration.
|
Ran the import process manually and it appears to have worked. Prod Table has data and no errors in log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes a new table available to the service catalogue,
amigo_bake_packages. This table will tell us at a glance what packages are installed on which Amigo bakes, and in conjunction with other tables in the catalogue will tell us what packages are installed on which EC2 instances and in which AWS accounts.Implementation
We add a new cloudformed task definition to ECS to run a CloudQuery job. The CQ job fetches data from the Amigo Dynamo DB tables and Amigo packagelist S3 objects and stores them in the new service catalogue table on a daily schedule.
The CQ job makes use of our new custom image package source plugin.
Testing
Tested on Code environment where the new task has run successfully and created the new table populated correctly with Code Amigo data.