p2: Detekt configuration clean up #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab-gnm
commented
Dec 9, 2024
There was a problem hiding this comment.
Moved to SetupDetekt.kt below.
| parallel = true | ||
|
|
||
| basePath = rootProject.projectDir.absolutePath | ||
| ignoredBuildTypes = listOf("release") |
There was a problem hiding this comment.
This is the additional change here - ignoring release builds.
ab-gnm
changed the title
EnochHankombo92
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Project-setupDetekt()setupDetektfunction to all module convention plugins - application, android library, kotlin library and test modulesThis change means we don't need to remember to apply the plugin specifically to each module.
Another change is that we now only apply the plugin to debug builds. This doesn't make a difference in practice - we only have a single source set. But it makes a small improvement in build time since release sourceset tasks don't have to be configured and run.
Testing notes/instructions:
Ensure detekt checks pass below.
Checklist