Skip to content

Commit

Permalink
Fix app.kubernetes.io labels to use $ instead of . in vaultwarden cha…
Browse files Browse the repository at this point in the history
…rt (#77)

This commit changes the way the `app.kubernetes.io/name` and `app.kubernetes.io/instance` labels are generated in the vaultwarden Helm chart. Previously, the `.Values` object was used directly within the template expression, which is not allowed by Helm. This change updates the expression to use the `$` symbol, which correctly references the current values context.
  • Loading branch information
dolohow authored Feb 23, 2024
1 parent 5b80986 commit 04820b4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/vaultwarden/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ maintainers:
- name: guerzon
email: [email protected]
url: https://github.com/guerzon
version: 0.22.2
version: 0.22.3
kubeVersion: ">=1.12.0-0"
8 changes: 4 additions & 4 deletions charts/vaultwarden/templates/_pvcSpec.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ volumeClaimTemplates:
name: {{ .name }}
labels:
app.kubernetes.io/component: vaultwarden
app.kubernetes.io/name: {{ include "vaultwarden.fullname" . }}
app.kubernetes.io/instance: {{ include "vaultwarden.fullname" . }}
app.kubernetes.io/name: {{ include "vaultwarden.fullname" $ }}
app.kubernetes.io/instance: {{ include "vaultwarden.fullname" $ }}
annotations:
meta.helm.sh/release-name: {{ $.Release.Name | quote }}
meta.helm.sh/release-namespace: {{ $.Release.Namespace | quote }}
Expand All @@ -29,8 +29,8 @@ volumeClaimTemplates:
name: {{ .name }}
labels:
app.kubernetes.io/component: vaultwarden
app.kubernetes.io/name: {{ include "vaultwarden.fullname" . }}
app.kubernetes.io/instance: {{ include "vaultwarden.fullname" . }}
app.kubernetes.io/name: {{ include "vaultwarden.fullname" $ }}
app.kubernetes.io/instance: {{ include "vaultwarden.fullname" $ }}
annotations:
meta.helm.sh/release-name: {{ $.Release.Name | quote }}
meta.helm.sh/release-namespace: {{ $.Release.Namespace | quote }}
Expand Down

0 comments on commit 04820b4

Please sign in to comment.