Push Notifications existing secret #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…secrets for Bitwarden installation id and key. Alternative to defining sensitive secret values as a string in values.yaml. Based on the implementation of the smtp settings.
|
Thanks for the PR @Yannik26. Please also bump the chart version here: |
|
Thank you for your response @guerzon. I bumped the chart version to 0.24.2, current one is 0.24.1 |
dc-tec
referenced
this pull request
in dc-tec/k8s-gitops
Sep 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden](https://redirect.github.com/guerzon/vaultwarden) | HelmChart | minor | `0.24.1` -> `0.25.2` | --- ### Release Notes <details> <summary>guerzon/vaultwarden (vaultwarden)</summary> ### [`v0.25.2`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.25.2) [Compare Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.25.1...v0.25.2) vaultwarden is an unofficial Bitwarden-compatible server written in Rust #### What's Changed - fix: incomplete fix, additional by [@​guerzon](https://redirect.github.com/guerzon) in [https://github.com/guerzon/vaultwarden/pull/113](https://redirect.github.com/guerzon/vaultwarden/pull/113) **Full Changelog**: guerzon/vaultwarden@v0.25.1...v0.25.2 ### [`v0.25.1`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.25.1) [Compare Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.25.0...v0.25.1) vaultwarden is an unofficial Bitwarden-compatible server written in Rust #### What's Changed - fix: make customHeadersConfigMap optional by [@​guerzon](https://redirect.github.com/guerzon) in [https://github.com/guerzon/vaultwarden/pull/112](https://redirect.github.com/guerzon/vaultwarden/pull/112) **Full Changelog**: guerzon/vaultwarden@v0.25.0...v0.25.1 ### [`v0.25.0`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.25.0) [Compare Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.4...v0.25.0) vaultwarden is an unofficial Bitwarden-compatible server written in Rust #### What's Changed - feat: Replace nginx snippet annotation with custom header annotation by [@​HerrSpeck](https://redirect.github.com/HerrSpeck) in [https://github.com/guerzon/vaultwarden/pull/106](https://redirect.github.com/guerzon/vaultwarden/pull/106) #### New Contributors - [@​HerrSpeck](https://redirect.github.com/HerrSpeck) made their first contribution in [https://github.com/guerzon/vaultwarden/pull/106](https://redirect.github.com/guerzon/vaultwarden/pull/106) **Full Changelog**: guerzon/vaultwarden@v0.24.4...v0.25.0 ### [`v0.24.4`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.24.4) [Compare Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.3...v0.24.4) vaultwarden is an unofficial Bitwarden-compatible server written in Rust #### What's Changed - service: use selectorLabels helper by [@​craigcabrey](https://redirect.github.com/craigcabrey) in [https://github.com/guerzon/vaultwarden/pull/95](https://redirect.github.com/guerzon/vaultwarden/pull/95) #### New Contributors - [@​craigcabrey](https://redirect.github.com/craigcabrey) made their first contribution in [https://github.com/guerzon/vaultwarden/pull/95](https://redirect.github.com/guerzon/vaultwarden/pull/95) **Full Changelog**: guerzon/vaultwarden@v0.24.3...v0.24.4 ### [`v0.24.3`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.24.3) [Compare Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.2...v0.24.3) vaultwarden is an unofficial Bitwarden-compatible server written in Rust #### What's Changed - fix: add flag to enable notifications service by [@​guerzon](https://redirect.github.com/guerzon) in [https://github.com/guerzon/vaultwarden/pull/110](https://redirect.github.com/guerzon/vaultwarden/pull/110) **Full Changelog**: guerzon/vaultwarden@v0.24.2...v0.24.3 ### [`v0.24.2`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.24.2) [Compare Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.1...v0.24.2) vaultwarden is an unofficial Bitwarden-compatible server written in Rust #### What's Changed - Push Notifications existing secret by [@​Yannik26](https://redirect.github.com/Yannik26) in [https://github.com/guerzon/vaultwarden/pull/107](https://redirect.github.com/guerzon/vaultwarden/pull/107) #### New Contributors - [@​Yannik26](https://redirect.github.com/Yannik26) made their first contribution in [https://github.com/guerzon/vaultwarden/pull/107](https://redirect.github.com/guerzon/vaultwarden/pull/107) **Full Changelog**: guerzon/vaultwarden@v0.24.1...v0.24.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=--> Co-authored-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable use of existing secrets for bitwarden installation id and key for push notifications.
Both, installation key and id, shouldn't be made public when deploying via gitops. This enables using a seperate (encrypted) secret for defining installation id and key.
Based on the smtp configuration
New section in values.yaml looks the following:
It is possible to specify a string value in installationId.value or installationKey.value.
My implementation contains a breaking change due to the indroduction of installationId.value and installationKey.value instead of defining the id and key directly.