Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit to add additional volumes for sidecar containers in statefulset.yaml #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fgionghi
Copy link

@fgionghi fgionghi commented Mar 9, 2023

I'm using vaultwarden-backup as a sidecar container, but it also needs to mount a second volume for its configuration. At the moment I can't do it with your chart.

I achived that with the little modification I'm proposing
Then, in my values.yaml I'm using it as I would do in a normal statefulset:

additionalVolumes:
  volumes:
    - configMap:
        name: vaultwarden-backup-rclone-config
      name: vaultwarden-backup-rclone-config

@vincentscode
Copy link

Is there anything still left to be done before this feature can be added?

Copy link
Contributor

@santiagon610 santiagon610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if you're adding a feature, could you bump the minor version of Chart.yaml please?

@vincentscode
Copy link

Perhaps some documentation should also be added as this changes the available values?

@guerzon
Copy link
Owner

guerzon commented Oct 30, 2024

It's possible the contributor might no longer be active. Someone can submit the PR, otherwise, I can also add the changes myself.

@vincentscode
Copy link

It's possible the contributor might no longer be active. Someone can submit the PR, otherwise, I can also add the changes myself.

It seems they are no longer active. Would you mind adding the changes to resolve this?

@guerzon
Copy link
Owner

guerzon commented Dec 13, 2024

Hello, I will find time to add this in the next couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants