Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where pvc range produced multiple volume keys #137

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

paimonsoror
Copy link
Contributor

@paimonsoror paimonsoror commented Dec 1, 2024

Resolves #135

Confirmed the following via tests:

  • Inclusion of storage.existingVolumeClaim does not create a volume key in the deployment
  • Omitting storage.existingVolumeClaim and creating either/or/both of storage.data / storage.attachments creates a single volume key with children for each

image

(dont judge my test keys lol as i had to spoof the volumeClaim names to avoid errors with includes in my test)

Copy link
Contributor

@santiagon610 santiagon610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@paimonsoror
Copy link
Contributor Author

@guerzon how are you feeling about this one

@guerzon guerzon merged commit 1bb422c into guerzon:main Dec 4, 2024
1 check passed
@guerzon
Copy link
Owner

guerzon commented Dec 5, 2024

Thanks @paimonsoror for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.31.0 removes data volume from deployment
3 participants