Websocket via legacy custom implementation disabled by default #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
Moreover, using
$connection_upgrade
as the recommended Proxy Header for Connection. I checked Ingress config, and it already has the mapping for both headers-values. So, if people want to use thekeep-alive
they can still set that value underingress
.Websockets working via Rocket using the values provided by this PR. Proofs:
Ingress Controller Logs:
Web browser simultaneous session (creating an item in a private tab, immediately shows the item in the other browser):