Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onPress #97

Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat: add onPress #97

merged 3 commits into from
Sep 19, 2024

Conversation

ameer-taghavi
Copy link
Contributor

add onPress props, close #96

Test plan

Added examples to ToastDemo. added OnPress action button at last.

@gunnartorfis
Copy link
Owner

@ameer-taghavi thanks for the PR.
I changed the functionality just a tiny bit. Now, enabled doesn't check for onPress, since the enabled prop is just meant to control the dismissability. If you want the tap to be disabled, don't pass the onPress prop.

Could you test out the new changes and see if they're working as intended?

@ameer-taghavi
Copy link
Contributor Author

Ok, I'll test it

@ameer-taghavi
Copy link
Contributor Author

@gunnartorfis,
I tested and everything is ok

@gunnartorfis gunnartorfis requested a review from hyoban September 18, 2024 10:43
@gunnartorfis gunnartorfis merged commit 4cfe534 into gunnartorfis:main Sep 19, 2024
3 checks passed
@gunnartorfis gunnartorfis mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyoban hyoban hyoban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] add onPress props
3 participants
@ameer-taghavi @gunnartorfis @hyoban