SNR optimisation options for pycbc_live #4398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the two pre-requisites are now merged. Do you want to rebase and look over CodeClimates before this is considered?? |
|
Will have a look at this hopefully as some point this week, I think there is a few new options to add for the initial array and then just checking there are no merge conflicts 👍 |
|
Seems like some git gardening (conflicts ..) is needed |
|
Remade in #4432. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #4290.
Will need to wait for PRs #4176 & #4393 to be merged and then this branch can be rebased + conflicts resolved.
The goal is to pass the
pycbc_optimize_snrcommand line options through to PyCBC Live so the optimizer can be customized during the pycbc live search. Currently only default values are taken and these are not necessarily the best options.