-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get.sh in LISA LDC doc example #4532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This should fix an issue being seen in the CI tests. Please merge when the tests pass.
Looks like there is one more place zenodo is used to get data - here for reference - but that does not use curl, and seems to work |
@GarethCabournDavies Good spot, I will also run that function to make sure. |
* Read DQ flags with finer time resolution (#4547) * Read DQ flags with finer time resolution * No default sample rate for dq flags * No default sample rate for dq * Add type for frequency command line option * Optimize memory usage of pycbc_fit_sngls_split_binned (#4543) * Optimize memory usage of pycbc_fit_sngls_split_binned * Need add option here * Comments on PR * Example doesn't use code being edited! * Update bin/all_sky_search/pycbc_fit_sngls_split_binned Co-authored-by: Thomas Dent <[email protected]> --------- Co-authored-by: Thomas Dent <[email protected]> * Non-coinc ifos in minifollowup trig plots (#4548) * Update get.sh (#4532) --------- Co-authored-by: maxtrevor <[email protected]> Co-authored-by: Thomas Dent <[email protected]> Co-authored-by: Shichao Wu <[email protected]>
@spxiwh Please check it. This PR fixes the curl issue.