Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get.sh in LISA LDC doc example #4532

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

WuShichao
Copy link
Contributor

@spxiwh Please check it. This PR fixes the curl issue.

@WuShichao WuShichao requested a review from spxiwh October 13, 2023 15:12
@WuShichao WuShichao added the LISA label Oct 13, 2023
Copy link
Contributor

@spxiwh spxiwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should fix an issue being seen in the CI tests. Please merge when the tests pass.

@WuShichao WuShichao enabled auto-merge (squash) October 13, 2023 15:14
@GarethCabournDavies
Copy link
Contributor

GarethCabournDavies commented Oct 13, 2023

Looks like there is one more place zenodo is used to get data - here for reference - but that does not use curl, and seems to work

@WuShichao
Copy link
Contributor Author

@GarethCabournDavies Good spot, I will also run that function to make sure.

@WuShichao WuShichao merged commit 03f64a2 into gwastro:master Oct 13, 2023
31 checks passed
@WuShichao WuShichao deleted the fix_zenodo branch October 13, 2023 17:15
@gwastro gwastro deleted a comment Oct 16, 2023
spxiwh pushed a commit to spxiwh/pycbc that referenced this pull request Nov 2, 2023
spxiwh added a commit that referenced this pull request Nov 3, 2023
* Read DQ flags with finer time resolution (#4547)

* Read DQ flags with finer time resolution

* No default sample rate for dq flags

* No default sample rate for dq

* Add type for frequency command line option

* Optimize memory usage of pycbc_fit_sngls_split_binned (#4543)

* Optimize memory usage of pycbc_fit_sngls_split_binned

* Need add option here

* Comments on PR

* Example doesn't use code being edited!

* Update bin/all_sky_search/pycbc_fit_sngls_split_binned

Co-authored-by: Thomas Dent <[email protected]>

---------

Co-authored-by: Thomas Dent <[email protected]>

* Non-coinc ifos in minifollowup trig plots (#4548)

* Update get.sh (#4532)

---------

Co-authored-by: maxtrevor <[email protected]>
Co-authored-by: Thomas Dent <[email protected]>
Co-authored-by: Shichao Wu <[email protected]>
PRAVEEN-mnl pushed a commit to PRAVEEN-mnl/pycbc that referenced this pull request Nov 3, 2023
maxtrevor pushed a commit to maxtrevor/pycbc that referenced this pull request Dec 11, 2023
bhooshan-gadre pushed a commit to bhooshan-gadre/pycbc that referenced this pull request Mar 4, 2024
lpathak97 pushed a commit to lpathak97/pycbc that referenced this pull request Mar 13, 2024
acorreia61201 pushed a commit to acorreia61201/pycbc that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants