Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick things onto v23 release branch #4551

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

spxiwh
Copy link
Contributor

@spxiwh spxiwh commented Nov 2, 2023

There are already-reviewed commits that need merging onto the v23 release branch. Last call if anyone wants to add anything else, please comment the number below.

Please let me merge this so that the commits don't get squashed!

maxtrevor and others added 3 commits November 2, 2023 06:08
* Read DQ flags with finer time resolution

* No default sample rate for dq flags

* No default sample rate for dq

* Add type for frequency command line option
* Optimize memory usage of pycbc_fit_sngls_split_binned

* Need add option here

* Comments on PR

* Example doesn't use code being edited!

* Update bin/all_sky_search/pycbc_fit_sngls_split_binned

Co-authored-by: Thomas Dent <[email protected]>

---------

Co-authored-by: Thomas Dent <[email protected]>
@GarethCabournDavies
Copy link
Contributor

GarethCabournDavies commented Nov 2, 2023

#4549 if possible, but don't hold things up for too long Go ahead without this

@spxiwh
Copy link
Contributor Author

spxiwh commented Nov 2, 2023

Needed to add one patch to resolve a test case failure.

@spxiwh spxiwh merged commit 7b571ed into gwastro:v23_release_branch Nov 3, 2023
31 checks passed
@spxiwh spxiwh deleted the pr_update_v23_branch branch November 3, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants