Passing vetoes to scripts in pygrb results sub workflow #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titodalcanton
approved these changes
Nov 14, 2024
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Passing segments files and vdf to all results scripts from pycbc_pygrb_results_workflow * Generalised functions involved in loading trigger/injeciton data in pygrb * Updating pycbc_pygrb_plot_skygrid accordingly * Typo in comment * No f-string in logging * Improved a logging message and 2 code comments * Renaming variable that was forgotten * Removed redundant variable * Blending _load_triggers into load_data * Blending _load_triggers into load_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second in the series started in PR #4929.
Standard information about the request (and the following ones that will be linked to this)
This is a: a new feature enabling veto definer file usage in PyGRB. Utilities and scripts in results production are being streamlined along the way.
This change affects: PyGRB
This change changes: result presentation / plotting and scientific output.
If this change breaks the standard automated test running
--helpfor PyGRB plotting scripts, I will add some workarounds to avoid this. If needed, these will likely be empty functions: the plotting scripts will be progressively renovated in the whole series of PRs.Motivation
Prior to these PRs, PyGRB was not using data vetoes.
Contents
pycbc_pygrb_plot_skygridwas updated accordingly as a first example.Testing performed
The totality of the changes that will be broken down in multiple PRs was tested on GRB 170817A data by producing a full results webpage (see here).