Fix issue preventing extract samples from combining files #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame when combining files
ahnitz
approved these changes
Nov 12, 2024
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
…ame when combining files (gwastro#4935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pycbc_inference_extract_samplesis supposed to be able to combine files. However, this functionality is currently broken because it tries to enforce that therun_start_timeandrun_end_timethat is stored in the input files be the same. This patch fixes that by addingrun_start_timeandrun_end_timeto the list of file attrs that are ignored when combining files.