Fix bug when plotting maximum likelihood point in create_multidim_plot
#4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorreia61201
changed the title
pycbc_inference_plot_posteriorcreate_multidim_plot
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix to the
create_multidim_plotfunction inscatter_histograms.py. Specifying--plot-maxldoes not plot the expected maximum likelihood point when used in conjunction with--plot-scatterin multidimensional plots. Currently,plot-maxlselects the index of the max likelihood sample beforeplot-scattersorts the samples by their z argument. When both options are specified, the selected maxL index will generally not correspond to the maxL sample in the newly sorted array.This PR moves the indexing selection for
plot-maxlafter the samples are sorted byplot-scatter. This should have no effect if using either option separately with codes usingcreate_multidim_plot(e.g.pycbc_inference_plot_posterior), but should now correctly plot the maxL sample if both are specified.