Deprecate and avoid unload event handler #9984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnehlmeier
reviewed
Aug 15, 2024
Also adds suggestions on how they can be returned to semi-reliability.
jnehlmeier
requested changes
Aug 16, 2024
jnehlmeier
reviewed
Aug 21, 2024
jnehlmeier
reviewed
Sep 6, 2024
jnehlmeier
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event handling for
unloadandbeforeunloadnow is split, so that only explicit calls toWindowImpl.initWindowCloseHandler(),Window.addCloseHandler(), orWindow.addWindowCloseListener()can cause theunloadevent handler to be attached - all of which are now deprecated. Thebeforeunloadevent wiring is now the only event handler set up whenWindow.addWindowClosingHandleretc are called.RootPanel methods formerly intended to prevent memory leaks during the
unloadevent are deprecated, since modern browsers do not leak these handlers, and may prevent correct behavior of apps using bfcache.Documentation changed on using various static wrap(Element) methods to reflect how to detach, if desired, when the page is closed or no longer in use.
Fixes #9908