fixed issue parsing numpy array of times when writing irregular ts #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing an irregular time series, there is a check to make sure that
times
exists as is either an instance oflist
ortuple
. However, while numpy arrays work fine for regular time series, it fails for irregular time series. In this PR I amended the problematic code to also accept numpy arrays when writing irregular time series. This check fails in its current form when given numpy arrays both becauseif not times
is ambiguous for an array andisinstance(times, (list, tuple))
evaluates toFalse
, so I changedif not times
toif times is None
(less ambiguous) and I allowedtimes
to be an instance of anumpy.ndarray
for irregular time series as well.