Db evidence selection #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and render functions.
… with the toggle to exclude db evidence
flag to the various functions that it calls.
added 15 commits
November 19, 2024 10:08
… from stmts hashes
…rom curators to explorators
…plates accordingly
…Update blueprint name and URL prefix from curator to explorator. Rename web interface related functions from curate to explore
… instead of Neo4j property
kkaris
reviewed
Nov 21, 2024
kkaris
reviewed
Nov 21, 2024
kkaris
reviewed
Nov 21, 2024
kkaris
reviewed
Nov 21, 2024
kkaris
reviewed
Nov 21, 2024
src/indra_cogex/apps/utils.py
Outdated
Comment on lines
256
to
273
| if isinstance(stmt, list): | ||
| stmt_hash, evidence = stmt[0], stmt[1] | ||
| row = _stmt_to_row( | ||
| stmt_hash, | ||
| evidence=evidence, | ||
| cur_dict=cur_dict, | ||
| cur_counts=cur_counts, | ||
| remove_medscan=remove_medscan, | ||
| source_counts=source_counts_per_hash.get(stmt_hash) if source_counts_per_hash else None, | ||
| ) | ||
| else: | ||
| row = _stmt_to_row( | ||
| stmt, | ||
| cur_dict=cur_dict, | ||
| cur_counts=cur_counts, | ||
| remove_medscan=remove_medscan, | ||
| source_counts=source_counts_per_hash.get(stmt.get_hash()) if source_counts_per_hash else None, | ||
| ) |
There was a problem hiding this comment.
Something is off here:
_stmt_to_rowtakes an indraStatementas its first argument, not a statement hash.- There is no kwarg for
evidence, yet it is passed in the when theifbranch of the code is executed.
kkaris
reviewed
Nov 21, 2024
| @@ -497,11 +503,21 @@ def indra_stmts_from_relations(rels: Iterable[Relation], | |||
| """ | |||
| stmts_json = [load_statement_json(rel.data["stmt_json"]) for rel in rels] | |||
| stmts = stmts_from_json(stmts_json) | |||
| # Beliefs are not set correctly in the JSON so we fix them here | |||
|
|
|||
| # Beliefs are not set correctly in the JSON, so we fix them here | |||
There was a problem hiding this comment.
I think it's actually fixed now.
There was a problem hiding this comment.
Do you want me to take it out or leave it as it is? Since it was already present earlier.
added 9 commits
November 21, 2024 15:27
…ts and fix: pass Statement object and remove unused evidence parameter in _stmt_to_row
…t for correct query syntax and added evidence prioritization with limit and filtering options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to merge the changes made for adding the statements with database evidences in the curation pages.