Fix task blocking #753
Merged
Fix task blocking #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
fix-task-blocking
branch
2 times, most recently
from
6737aff
to
8b944fe
Compare
…cking. Instead of incrementing the notificatin value via `xTaskNotifyGive` this will now set a specific bit in the task notification value which will be tested before blocking a task. This will prevent a task from blocking indefinitely if the event that calls `taskRelease` occurs before entering the blocked state. * Adds a config setting for the bit to set in the task notification value.
* Create destructor for NimBLETaskData to delete semaphore if created.
This change ensures that only the function that sets `m_pTaskData` clears it, potentially preventing a segmentation fault. * Client will no longer disconnect if task timeout occurs when waiting for MTU exchange response.
h2zero
force-pushed
the
fix-task-blocking
branch
from
8b944fe
to
8d73ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of incrementing the notificatin value via xTaskNotifyGive this will now set a specific bit in the task notification value
which will be tested before blocking a task. This will prevent a task from blocking indefinitely if the event that calls taskRelease
occurs before entering the blocked state.
Adds a config setting for the bit to set in the task notification value.
Refactor NimBLEClient::connect and NimBLEClient::secureConnection.
This change ensures that only the function that sets m_pTaskData clears it, potentially preventing a segmentation fault.
Client will no longer disconnect if task timeout occurs when waiting for MTU exchange response.